Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add 3.4 for CI #956

Merged
merged 1 commit into from
Feb 6, 2025
Merged

github: add 3.4 for CI #956

merged 1 commit into from
Feb 6, 2025

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Feb 6, 2025

No description provided.

Signed-off-by: Kentaro Hayashi <[email protected]>
Copy link
Collaborator

@Watson1978 Watson1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it fails tests with Ruby HEAD.
We might need to fix it with another PR...

@ohler55
Copy link
Owner

ohler55 commented Feb 6, 2025

Better to fix in this PR since the only change is the addition of another ruby version.

@Watson1978
Copy link
Collaborator

Watson1978 commented Feb 6, 2025

Ruby HEAD has been changed day by day.
So it can fail depending on when we run CI.

Seems this failure is due to recent changes in Ruby HEAD...

@ohler55
Copy link
Owner

ohler55 commented Feb 6, 2025

Fair enough.

@ohler55 ohler55 merged commit b61d931 into ohler55:develop Feb 6, 2025
47 of 52 checks passed
@kenhys kenhys deleted the update-ci branch February 7, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants